tqchen commented on PR #16067: URL: https://github.com/apache/tvm/pull/16067#issuecomment-1794967438
Thanks for the proposed change. I like how FNormalize can help reducing overhead of creating certain operators and bring them back to normal form. I only have one comment on the wellform check side. In this case, it is useful to have an intentionally duplicated check that is different from FNormalize , e.g. have a `TEnforceExplicitTupleInArgs` attribute that enforces the tuple argument being unpacked, and check this condition. This provides extra layer of protection, makes the intention clear and is also more efficient -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
