Lunderberg commented on PR #16067: URL: https://github.com/apache/tvm/pull/16067#issuecomment-1795153381
Thank you, and I like the overall design. I think we still want to keep all the normalization logic in `FNormalize`, without adding boolean flags for specific cases. The more boolean flags we have, the more difficult it is for a developer to know the rules for all flags. For example, a developer would need to check if the `TEnforceExplicitTupleInArgs` is used as part of the well-formed check, whether it triggers an assert during normalization, whether it triggers a normalization step during normalization, whether the normalization step applies when parsing TVMScript, etc. By implementing each of these features on top of the same `FNormalize` functionality, new operator-specific normalization rules can be implemented without adding to a developer's mental overhead. A developer only needs to know that the new normalization is handled the same as all existing integrations. (Also, see the other comment for performance benchmarking.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
