junrushao commented on code in PR #16092:
URL: https://github.com/apache/tvm/pull/16092#discussion_r1387390578
##########
include/tvm/relax/attrs/ccl.h:
##########
@@ -40,17 +40,21 @@ struct AllReduceAttrs : public
tvm::AttrsNode<AllReduceAttrs> {
}
}; // struct AllReduceAttrs
-/*! \brief Attributes used in scatter_from_worker0 operators */
-struct ScatterFromWorker0Attrs : public
tvm::AttrsNode<ScatterFromWorker0Attrs> {
+/*! \brief Attributes used in scatter operators */
+struct ScatterAttrs : public tvm::AttrsNode<ScatterAttrs> {
Review Comment:
Scatter is a bit ambiguous. It could mean an op or a communication
collective. What do you have a better naming specifically for this usecase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
