jinhongyii commented on code in PR #16092:
URL: https://github.com/apache/tvm/pull/16092#discussion_r1387409077
##########
include/tvm/relax/attrs/ccl.h:
##########
@@ -40,17 +40,21 @@ struct AllReduceAttrs : public
tvm::AttrsNode<AllReduceAttrs> {
}
}; // struct AllReduceAttrs
-/*! \brief Attributes used in scatter_from_worker0 operators */
-struct ScatterFromWorker0Attrs : public
tvm::AttrsNode<ScatterFromWorker0Attrs> {
+/*! \brief Attributes used in scatter operators */
+struct ScatterAttrs : public tvm::AttrsNode<ScatterAttrs> {
Review Comment:
Good point. I have no idea on this naming. @tqchen Do you have any
suggestions? This attr is expected to be reused by
R.dist.redistribute_replica_to_shard we discussed before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
