Archermmt commented on code in PR #16128:
URL: https://github.com/apache/tvm/pull/16128#discussion_r1396399759
##########
include/tvm/relax/transform.h:
##########
@@ -322,11 +322,20 @@ class FusionPatternNode : public Object {
*/
Optional<PackedFunc> check;
+ /*!
+ * \brief The function to get attributes for fused function
+ *
+ * It should have signature
+ * Map<String, String>(const PatternCheckContext& context)
Review Comment:
A context is needed to set extra attributes. The context should have access
to all expressions in the pattern, I find out that PatternCheckContext is a
good one. It contains all the expressions marked during pattern matching. Some
attributes need to be defined based on the expressions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
