masahi commented on code in PR #16128:
URL: https://github.com/apache/tvm/pull/16128#discussion_r1396423174
##########
include/tvm/relax/transform.h:
##########
@@ -322,11 +322,20 @@ class FusionPatternNode : public Object {
*/
Optional<PackedFunc> check;
+ /*!
+ * \brief The function to get attributes for fused function
+ *
+ * It should have signature
+ * Map<String, String>(const PatternCheckContext& context)
Review Comment:
What `CreatePatternCheckContext` does is very simple. I suggest extracting
what you need from there into a function, and use it in both here and inside
`CreatePatternCheckContext`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
