Lunderberg commented on code in PR #16183:
URL: https://github.com/apache/tvm/pull/16183#discussion_r1409864198
##########
include/tvm/runtime/packed_func.h:
##########
@@ -2129,6 +2315,42 @@ struct PackedFuncValueConverter<::tvm::runtime::String> {
}
};
+template <typename T>
+struct PackedFuncValueConverter<Array<T>> {
Review Comment:
Regarding performance, I think we should be good there as well. The
conversion is applied instead of the existing recursive check in
`ObjectTypeChecker<Array<T>>`, so no additional recursive walks. The mutation
is implemented in terms of `Array::Map`, which is copy-on-write, so no
allocations occur if the user has provided the expected types (the common case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
