Lunderberg commented on code in PR #16183:
URL: https://github.com/apache/tvm/pull/16183#discussion_r1410765731
##########
include/tvm/runtime/packed_func.h:
##########
@@ -2129,6 +2315,42 @@ struct PackedFuncValueConverter<::tvm::runtime::String> {
}
};
+template <typename T>
+struct PackedFuncValueConverter<Array<T>> {
Review Comment:
Sounds good, and going through the comments now. I like the idea of
updating the call sites over time, so that eventually the backwards
compatibility conversion would only be triggered for externally-defined
PackedFunc instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
