yelite commented on code in PR #16476:
URL: https://github.com/apache/tvm/pull/16476#discussion_r1468035951
##########
python/tvm/contrib/cutlass/gen_tensor_op.py:
##########
@@ -566,7 +566,10 @@ def get_flattened_batch_dim(arg_name, batch_rank):
transposed = "transposed" in func_name or "dense" in func_name
lhs_arg_idx = _get_optional_int_annotation(annotations, "lhs_arg_idx",
0)
rhs_arg_idx = _get_optional_int_annotation(annotations, "rhs_arg_idx",
1)
- bias_arg_idx = _get_optional_int_annotation(annotations,
"bias_arg_idx", None)
+ if "bias" in func_name:
+ bias_arg_idx = _get_optional_int_annotation(annotations,
"bias_arg_idx", 2)
Review Comment:
Maybe there is pattern with bias but doesn't have annotation? IIUC this code
path is shared between relax and relay. @creaiter can you share sample where
the bias parameter isn't generated correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
