churvey commented on code in PR #16476:
URL: https://github.com/apache/tvm/pull/16476#discussion_r1584157146
##########
python/tvm/contrib/cutlass/gen_tensor_op.py:
##########
@@ -566,7 +566,10 @@ def get_flattened_batch_dim(arg_name, batch_rank):
transposed = "transposed" in func_name or "dense" in func_name
lhs_arg_idx = _get_optional_int_annotation(annotations, "lhs_arg_idx",
0)
rhs_arg_idx = _get_optional_int_annotation(annotations, "rhs_arg_idx",
1)
- bias_arg_idx = _get_optional_int_annotation(annotations,
"bias_arg_idx", None)
+ if "bias" in func_name:
+ bias_arg_idx = _get_optional_int_annotation(annotations,
"bias_arg_idx", 2)
Review Comment:
> if bias is used in the pattern (func name), it should exist in the
annotation. cc @yelite
It seems bias_arg_idx only annotated in relax, so partition_for_cutlass is
broken in relay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
