Lunderberg commented on code in PR #16523:
URL: https://github.com/apache/tvm/pull/16523#discussion_r1479921289
##########
src/arith/rewrite_simplify.h:
##########
@@ -221,6 +221,8 @@ class RewriteSimplifier::Impl : public
IRMutatorWithAnalyzer {
bool CanProveGreaterEqual(const PrimExpr& x, int64_t val) {
return analyzer_->CanProveGreaterEqual(x, val);
}
+ // Whether the lanes are scalable
+ bool ScalableLanes(const PrimExpr& lanes) { return !lanes.as<IntImmNode>(); }
Review Comment:
Seconding the stricter checks here. As it is, this function would state
that `Mul(2, 3)` is a scalable expression, because it is something other than
an integer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
