tqchen commented on code in PR #16523:
URL: https://github.com/apache/tvm/pull/16523#discussion_r1479943939
##########
include/tvm/runtime/data_type.h:
##########
@@ -90,7 +91,10 @@ class DataType {
/*! \return number of bytes to store each scalar. */
int bytes() const { return (bits() + 7) / 8; }
/*! \return number of lanes in the data. */
- int lanes() const { return static_cast<int>(data_.lanes); }
+ int lanes() const {
Review Comment:
it might be useful to distinguish between lanes and vscale_factor, by having
two functions, only allow lanes to corresponds to static vector lanes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
