slyubomirsky opened a new pull request, #16569: URL: https://github.com/apache/tvm/pull/16569
As discussed in several TVM Open Development meetings, we were permitting invalid programs to be parsed by not checking well-formedness during parsing. This PR makes a small change to the parser to check well-formedness proactively, though this required correcting bugs in tests (in a couple of cases, tests of error cases that were deliberately malformed became harder to construct but this is likely an acceptable tradeoff). I had held off on making this PR until [this PR on MLC-LLM](https://github.com/mlc-ai/mlc-llm/pull/1696), which ensured that there would not be invalid constructs in models constructed by MLC-LLM. One issue is that the well-formed checker does not create the most readable error messages. If the normalizer's error reporting could also be used in the well-formed checker, that would be a useful change to make as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
