slyubomirsky commented on code in PR #16569:
URL: https://github.com/apache/tvm/pull/16569#discussion_r1488887326
##########
tests/python/relax/test_transform_operator_specific_normalization.py:
##########
@@ -261,9 +303,9 @@ def multiply_by_two(A: T.Buffer(16, "float32"), B:
T.Buffer(16, "float32")):
def test_normalize_to_inline_tuple_for_call_tir_inplace(custom_op):
"""FNormalize in-lines the argument tuple for R.call_tir_inplace"""
- # The CallTIRInplaceAttrs cannot be constructed from the Python
- # API. Therefore, declaring the Expected output first, so that
- # the attributes can be used for the non-normalized Before.
Review Comment:
I am pretty sure it is possible to construct attrs in Python (I've done it
for Relay) but it's very tedious, so I corrected the comment. It is definitely
easier to rely on the one that will be constructed on the C++ side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
