tqchen commented on code in PR #16542:
URL: https://github.com/apache/tvm/pull/16542#discussion_r1489469477
##########
include/tvm/runtime/relax_vm/bytecode.h:
##########
@@ -183,10 +184,15 @@ struct Instruction {
/*! \brief The instruction opcode. */
Opcode op;
union {
- struct /* Call */ {
+ struct /* Call, CallFromRegister */ {
/*! \brief The destination register. */
RegName dst;
- /*! \brief The index into the packed function table. */
+ /*! \brief The index of the function.
+ *
+ * For `OpCode::Call`, this is an index into the table of static
Review Comment:
we should not use CallFromRegister, instead we should lower to
https://github.com/apache/tvm/blob/main/src/runtime/relax_vm/builtin.cc#L373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
