tqchen commented on PR #16542: URL: https://github.com/apache/tvm/pull/16542#issuecomment-1943784574
Sorry for being late on this one. In this particular case, it is better to use `vm.builtin.invoke_closure` to lower those possible variables that contains the Callable. There are two reasons for this - One goal of relax VM is to ensure minimal set of instructions, so far we have been keeping the miminum variant via Call and all the rest call variant using builtins like `vm.builtin.invoke_closure` - We need to handle the case where callback is either a PackedFunc or Closure, `invoke_closure` handles the case. This enables reuse for compiled cases @Lunderberg would be great to followup on this soon given this would change some binary format of the VM https://github.com/apache/tvm/blob/main/src/runtime/relax_vm/builtin.cc#L373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
