Lunderberg commented on code in PR #16571:
URL: https://github.com/apache/tvm/pull/16571#discussion_r1489670752
##########
src/target/source/codegen_webgpu.h:
##########
@@ -40,14 +40,15 @@ namespace codegen {
* \brief WebGPU code generator.
*
* Note WGSL have a different syntax from normal C.
- * We only leevrage the C for expression generation and
+ * We only leverage the C for expression generation and
* write most of the language generations.
*/
class CodeGenWebGPU final : public CodeGenC {
public:
explicit CodeGenWebGPU(Target target);
// overrides
std::string Finish() final;
+ using CodeGenC::AddFunction;
Review Comment:
I assume this is for silencing a warning about shadowing
`CodeGenC::AddFunction`? If so, could we instead remove the
`skip_readonly_decl` argument altogether?
The `CodeGenWebGPU::AddFunction` method is only ever called
[here](https://github.com/apache/tvm/blob/main/src/target/source/codegen_webgpu.cc#L723),
and it is always passed `false`. I'm wondering if it should be part of the
`CodeGenWebGPU` constructor instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
