Hzfengsy commented on code in PR #16571:
URL: https://github.com/apache/tvm/pull/16571#discussion_r1489747014
##########
src/target/source/codegen_webgpu.h:
##########
@@ -40,14 +40,15 @@ namespace codegen {
* \brief WebGPU code generator.
*
* Note WGSL have a different syntax from normal C.
- * We only leevrage the C for expression generation and
+ * We only leverage the C for expression generation and
* write most of the language generations.
*/
class CodeGenWebGPU final : public CodeGenC {
public:
explicit CodeGenWebGPU(Target target);
// overrides
std::string Finish() final;
+ using CodeGenC::AddFunction;
Review Comment:
Thanks for your comment, but I'm not sure if it helps. As [stack
overflow](https://stackoverflow.com/questions/18515183/c-overloaded-virtual-function-warning-by-clang)
says, the warning happens if the functions have the same names but different
signatures.
Indeed, there are different solutions, like renaming
`CodeGenWebGPU::AddFunction`. Meanwhile, I think it's also fine to use `using
CodeGenC::AddFunction;`, as the compiler will import the function automatically
and implicitly.
I have no personal preference. I would love to follow up if you have a
strong opinion on a specific solution :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
