Lunderberg commented on code in PR #16618:
URL: https://github.com/apache/tvm/pull/16618#discussion_r1500776496


##########
python/tvm/runtime/__init__.py:
##########
@@ -40,3 +40,4 @@
 )
 
 from . import executor
+from . import disco

Review Comment:
   Hmm, good point.  The `tvm._ffi.register_object("runtime.disco.*")` calls 
would raise an error if disco isn't available.
   
   This was primarily to ensure that all packaged funcs generated by 
`tvm.runtime.disco` were available within the disco sub-process.  I'll try a 
build without disco enabled, and see what is required to make sure that the 
module import works either way.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to