Lunderberg commented on code in PR #16618: URL: https://github.com/apache/tvm/pull/16618#discussion_r1500782538
########## python/tvm/runtime/__init__.py: ########## @@ -40,3 +40,4 @@ ) from . import executor +from . import disco Review Comment: Looks like disco is enabled by default, and is always included in `libtvm_runtime.so` ([`CMakeLists.txt` link](https://github.com/apache/tvm/blob/main/CMakeLists.txt#L367). As a result, it should always be safe to import `tvm.runtime.disco`. If we later add a cmake flag to disable disco, we should be able to gate this import behind a check on `tvm.support.libinfo()[cmake_flag]`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
