Lunderberg commented on PR #16805:
URL: https://github.com/apache/tvm/pull/16805#issuecomment-2028982383

   I don't think there's any indication of this being a bug in the pass itself. 
 I also don't know if it's a rare case, only that I encountered it within one 
specific pass.  I think this is a bug in the general `relax::BlockBuilder` 
utility, as nothing in the API suggests that use of `AddFunc` and `UpdateFunc` 
within the same transform is unsupported.  If we want to avoid complexity in 
the `relax::BlockBuilder`, then we should remove the function-level 
de-duplication from `relax::BlockBuilder` altogether, and handle it in a 
dedicated transform.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to