Lunderberg commented on PR #16805: URL: https://github.com/apache/tvm/pull/16805#issuecomment-2029767747
Rephrasing, I agree that we should minimize the complexity of implementations. However, I think that must be done by choosing which features to offer within an implementation. Since `relax::BlockBuilder` already provides de-duplication, and allows passes to freely use both `AddFunc` and `UpdateFunc`, the complexity in this implementation is complexity that we've already committed to. I think we should merge this PR, as it resolves a bug in the current feature set provided by `relax::BlockBuilder`. To reduce the complexity of `relax::BlockBuilder`, a follow-up change can try moving the de-duplication of functions into a separate pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
