tqchen commented on PR #16836: URL: https://github.com/apache/tvm/pull/16836#issuecomment-2034865933
the only main issue about generate approach is that it may not be comprehensive if we in the end link multiple exports together, which is a less frequent usecase as in static library case(where we append the symbol prefix). I think this is more of an optional feature rather than mandatory feature, so we should avoid exposing it as things like `keys`, but maybe use some of the info if available for error reporting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
