Lunderberg commented on PR #16836: URL: https://github.com/apache/tvm/pull/16836#issuecomment-2034997679
> the only main issue about generate approach is that it may not be comprehensive if we in the end link multiple exports together, which is a less frequent usecase as in static library case(where we append the symbol prefix). That's a good point, though I believe we'll have the correct behavior by default. For both the `mod.imported_modules` and the static libraries, the user should only be calling the functions through the externally-exposed wrappers in `mod`. These are the names present in the `IRModule` itself. (As an extension, we could indicate which functions are present within the static and/or imported modules, but that would be a later extension.) > I think this is more of an optional feature rather than mandatory feature, so we should avoid exposing it as things like `keys`, but maybe use some of the info if available for error reporting I think we want to expose it to the user, for use debugging. If a user receives an error message with suggested typo corrections, or stating that there no similarly named functions, the obvious next step is to look at what functions actually are available. Since `runtime.Module` already provides `__getitem__` like a python dictionary, other dictionary-like methods such as `.keys()` would be the obvious place for a new developer to look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
