masahi commented on code in PR #16750:
URL: https://github.com/apache/tvm/pull/16750#discussion_r1571354007
##########
include/tvm/runtime/memory/memory_manager.h:
##########
@@ -157,7 +160,7 @@ class StorageObj : public Object {
/*! \brief reference to storage. */
class Storage : public ObjectRef {
public:
- TVM_DLL explicit Storage(Buffer buffer);
+ TVM_DLL explicit Storage(Buffer buffer, Allocator* allocator);
Review Comment:
Is this constructor actually used? In this PR I only see manual attachment
like `storage_obj->allocator = allocator;`.
We started to see a segfault like `free(): invalid pointer` when a python
process that runs a script exits, after we integrated recent upstream changes.
I'm investigating if the segfault is really due to some recent upstream
changes, and which one if so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
