MasterJH5574 commented on code in PR #16750:
URL: https://github.com/apache/tvm/pull/16750#discussion_r1571503460
##########
include/tvm/runtime/memory/memory_manager.h:
##########
@@ -157,7 +160,7 @@ class StorageObj : public Object {
/*! \brief reference to storage. */
class Storage : public ObjectRef {
public:
- TVM_DLL explicit Storage(Buffer buffer);
+ TVM_DLL explicit Storage(Buffer buffer, Allocator* allocator);
Review Comment:
I see. Can we just check the allocator is defined by adding ICHECK in the
destructor, or change all `make_object` to use the constructor and add ICHECK
inside? If I remember correctly, I made a pass over all occurrences and
attached the allocators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
