lhutton1 commented on code in PR #16966:
URL: https://github.com/apache/tvm/pull/16966#discussion_r1599992854
##########
src/tir/transforms/vectorize_loop.cc:
##########
@@ -72,6 +72,126 @@ inline PrimExpr BroadcastTo(PrimExpr e, int lanes, bool
is_scalable) {
return Broadcast(e, CreateNewLanes(is_scalable, lanes));
}
+bool EnableBufferLevelPredication() {
Review Comment:
Thanks for the detailed description. To save the number of changes in this
PR getting even larger, I've added the minimum changes necessary for the
vectorizer pass. Perhaps we can clean this up and fix the target checks in the
analyzer in a separate PR?
Edit: on second thoughts, I'm not sure how the analyzer should behave when
the target has been overridden. Should the analyzer constructor now accept a
`Target` parameter which can be passed on to the sub analyzers that require it?
Propagating `Target` correctly from all passes that make use of the Analyzer
seems like quite a big task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
