Lunderberg commented on code in PR #16966:
URL: https://github.com/apache/tvm/pull/16966#discussion_r1598722953
##########
python/tvm/tir/buffer.py:
##########
@@ -141,6 +141,57 @@ def vstore(self, begin, value):
begin = (begin,) if isinstance(begin, (int, PrimExpr)) else begin
return _ffi_api.BufferVStore(self, begin, value) # type: ignore
+ def load(self, indices, predicate=None):
Review Comment:
Ah, I see. I think this is an unfortunate confusion resulting from the name
`begin` for the parameter in `vload` and `vstore`. This parameter would be
better named `indices`, because it is used to set the `indices` argument of the
buffer load/store.
While there's some additional logic to handle automatic promotion from a
scalar index to a vector index when needed
([link](https://github.com/apache/tvm/blob/main/src/tir/ir/buffer.cc#L410)), a
vector index can also be provided directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
