Lunderberg commented on code in PR #17216:
URL: https://github.com/apache/tvm/pull/17216#discussion_r1698614921
##########
src/relax/op/op.cc:
##########
@@ -331,8 +331,133 @@ RELAY_REGISTER_OP("relax.call_tir")
.set_attr<FNormalize>("FNormalize", NormalizeCallTIR)
.set_attr<Bool>("FPurity", Bool(true));
-Expr MakeCallTIR(Expr func, Tuple args, Array<TensorStructInfo> out_sinfo_list,
+static Array<TensorStructInfo> InferCallTIROutputStructInfo(Expr func, Tuple
args,
Review Comment:
Absolutely agreed that we should check for consistency after generating the
IR, and that's something I want to add to the well-formed checker as well.
This specific PR would be to avoid inconsistency while generating the IR.
(And if we can't infer the output shape, then the output shape must still be
be explicitly provided.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
