Lunderberg commented on PR #17216: URL: https://github.com/apache/tvm/pull/17216#issuecomment-2260928013
> I think encouraging pass writers to explicitly think about the DPS pattern and always provide the return argument helps to reduce uncertainty here. While I think this would be an interesting point to discuss, I don't think it's relevant to this specific change. This PR keeps the exact same `out_sinfo` in the C++ IR types, and still requires pass writers to explicitly provide the output info. The `MakeCallTIR` function is not exposed to the back-end C++ API, only through the front-end Python API. This change is solely in the front-end, for cases where an `IRModule` is being hand-written. I'd like to make that use-case less error-prone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
