Thrsu commented on PR #17501: URL: https://github.com/apache/tvm/pull/17501#issuecomment-2460069328
> Hi @Thrsu, thanks for contributing! Actually we expect all dataflow blocks to have been removed in order to properly apply memory planning, given we no longer need the dataflow block information in subsequent lowering passes. Here is our lowering pipeline and you can see that we apply `ToNonDataflow` before other lowering passes, including the memory planning > > https://github.com/apache/tvm/blob/3e386fd3732778d5eb7998f23e2d940741102d9a/python/tvm/relax/pipeline.py#L89-L92 > > So if possible, do you mind sharing the reason why you want the memory planning pass to work with dataflow blocks? A code example may be sufficient, thanks! Thanks for your response! I want to customize a pass pipeline for exploring the possibility of improving the optimization performance. However, it crashed unexpectedly due to the assumptions about the pass. This PR aims to enable the StaticPlanBlockMemory optimization to run correctly in such conditions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
