Thrsu commented on PR #17501: URL: https://github.com/apache/tvm/pull/17501#issuecomment-2467114766
> @Thrsu I see. Thanks for elaborating! The memory planning pass also has a dependency on the `transform.CallTIRRewrite` pass, which you may also need to be careful about. Could you please add a unit test to this file, showing that the memory planning works for dataflow blocks? With the unit test we can merge this PR. Thanks! > > https://github.com/apache/tvm/blob/main/tests/python/relax/test_transform_static_plan_block_memory.py @MasterJH5574 Thank you for the guidance! I've added a unit test to the specified file, demonstrating that the memory planning pass works for dataflow blocks as requested. Could you please review the latest changes? Thank you for your time and assistance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
