Hzfengsy commented on code in PR #17803:
URL: https://github.com/apache/tvm/pull/17803#discussion_r2028018902
##########
include/tvm/tir/expr.h:
##########
@@ -261,6 +261,25 @@ class FloorDiv : public PrimExpr {
TVM_DEFINE_OBJECT_REF_COW_METHOD(FloorDivNode);
};
+/*!
+ * \brief LogAddExp operation, computes log(exp(a) + exp(b)).
+ */
+class LogAddExpNode : public BinaryOpNode<LogAddExpNode> {
Review Comment:
If you still need this one, for example, there is a hardware intrinsic.
Please move it to call_intrinsic, aka "tir.log_add_exp" similar to "tir.log"
and "tir.exp"
##########
include/tvm/tir/expr.h:
##########
@@ -261,6 +261,25 @@ class FloorDiv : public PrimExpr {
TVM_DEFINE_OBJECT_REF_COW_METHOD(FloorDivNode);
};
+/*!
+ * \brief LogAddExp operation, computes log(exp(a) + exp(b)).
+ */
+class LogAddExpNode : public BinaryOpNode<LogAddExpNode> {
Review Comment:
Why is such an operator needed in TIR? In my opinion, it's not a common
intrinsic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
