AishwaryaElango commented on code in PR #17803:
URL: https://github.com/apache/tvm/pull/17803#discussion_r2030959732


##########
include/tvm/tir/expr.h:
##########
@@ -261,6 +261,25 @@ class FloorDiv : public PrimExpr {
   TVM_DEFINE_OBJECT_REF_COW_METHOD(FloorDivNode);
 };
 
+/*!
+ * \brief LogAddExp operation, computes log(exp(a) + exp(b)).
+ */
+class LogAddExpNode : public BinaryOpNode<LogAddExpNode> {

Review Comment:
   So, I can decompose my Op in 
[src/tir/op/op.cc](https://github.com/apache/tvm/blob/main/src/tir/op/op.cc) 
rather than including it in 
[include/tvm/tir/expr.h](https://github.com/apache/tvm/blob/main/include/tvm/tir/expr.h)
   Is that right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to