masahi commented on a change in pull request #5262: [RELAY][BYOC] Register
pattern tables from external codegens
URL: https://github.com/apache/incubator-tvm/pull/5262#discussion_r408160065
##########
File path: python/tvm/relay/op/contrib/dnnl.py
##########
@@ -63,3 +65,23 @@ def _func_wrapper(attrs, args):
_register_external_op_helper("add")
_register_external_op_helper("subtract")
_register_external_op_helper("multiply")
+
+
+def make_pattern(with_bias=True):
+ data = _expr.var("data")
+ weight = _expr.var("weight")
+ bias = _expr.var("bias")
+ conv = reg.nn.conv2d(data, weight)
Review comment:
Why don't we import `op` as just `op`, rather than `reg`? `reg.nn.conv2d`
seems very weird...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
