masahi commented on a change in pull request #5262: [RELAY][BYOC] Register
pattern tables from external codegens
URL: https://github.com/apache/incubator-tvm/pull/5262#discussion_r408162468
##########
File path: tests/python/relay/test_pass_partition_graph.py
##########
@@ -903,17 +889,17 @@ def test_detect_pattern(pattern_table, include_bn,
include_sigmoid,
def test_partition():
# conv + bn + relu, conv + relu -> fused conv_bias_relu, conv, and relu
- test_detect_pattern([conv2d_bias_relu_pat], True, False, 3)
+ test_detect_pattern([dnnl_patterns[0]], True, False, 3)
Review comment:
better to make variables `conv2d_bias_relu_pat` and `conv2d_relu_pat` so that
* make the diff smaller
* less change if later somebody adds new patterns to the table and
`dnnl_patterns[0]` changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
