icemelon9 commented on a change in pull request #5319: [cuDNN] Add cuDNN
grouped convolution support
URL: https://github.com/apache/incubator-tvm/pull/5319#discussion_r408296595
##########
File path: src/runtime/contrib/cudnn/conv_forward.cc
##########
@@ -63,7 +64,8 @@ void ConvolutionForward(
// Note: For 2D tenor, using ND setters causes CUDNN_STATUS_NOT_SUPPORTED
error
// in following cudnnGetConvolutionForwardWorkspaceSize() when data type is
fp16, int
if (dims == 2) {
- // Set Desc
+ // Set Desc
+ CUDNN_CALL(cudnnSetConvolutionGroupCount(entry_ptr->conv_entry.conv_desc,
groups));
Review comment:
Since both if then and else have this, you should move this before the
if/else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
