icemelon9 commented on a change in pull request #5319: [cuDNN] Add cuDNN
grouped convolution support
URL: https://github.com/apache/incubator-tvm/pull/5319#discussion_r409777883
##########
File path: topi/python/topi/cuda/conv2d.py
##########
@@ -67,7 +67,7 @@ def _callback(op):
@autotvm.register_topi_compute("conv2d_cudnn.cuda")
def conv2d_cudnn(cfg, data, kernel, strides, padding, dilation, layout='NCHW',
- out_dtype='float32'):
+ out_dtype='float32', groups=1):
Review comment:
That's just my suggestion. I feel `groups` is more common than `out_dtype`.
Another reason is that `group_conv2d` also puts `groups` before `out_dtype`.
It'll be more consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
