comaniac edited a comment on issue #5409:
URL: https://github.com/apache/incubator-tvm/pull/5409#issuecomment-617912766
Thanks for the PR. Could you explain further about why the current solution
will pass constants between partitions? AFAIK, constant nodes should be
included in a subgraph if we bind the parameters.
Apart from the motivation, my understanding to PR is to create the following
graph:
```
input
|
begin
|
op -- const
|
end
```
where the constant input for `op` is not annotated.
Since now we require `AnnotateTarget` to annotate every op, and
`AnnotateRegionSet`, `MergeCompilerRegion` also require every op to be
annotated, could you elaborate if this change works for all of them? At first
glance, it might be a problem for `AnnotateRegionSet` to identify the region
inputs.
Following the above concern, could you also add this case to the unit tests
of other passes so that we can make sure the rest passes are covered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
