zhiics commented on a change in pull request #5438:
URL: https://github.com/apache/incubator-tvm/pull/5438#discussion_r414804149



##########
File path: python/tvm/ir/json_compact.py
##########
@@ -84,12 +91,26 @@ def _update_global_key(item, _):
         del item["global_key"]
         return item
 
+    def _update_from_std_str(key):
+        def _convert(item, nodes):
+            str_val = item["attrs"][key]
+            jdata = json.loads(tvm.ir.save_json(tvm.runtime.String(str_val)))

Review comment:
       Should we bring the serialization of tvm:String out of save_json? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to