tqchen commented on pull request #5438:
URL: https://github.com/apache/incubator-tvm/pull/5438#issuecomment-619211235


   @jroesch @zhiics 
   wrt to the String serialization. Right now String is serialized as an normal 
object. So if the content of String is printable, it will show up as
   
   ```python
   {type_key: "runtime.String", repr_str: "mystring"}
   ```
   
   If the content of the string is not printable, then it will show up as 
   
   ```python
   {type_key: "runtime.String", repr_b64: "base64encoding"}
   ```
   
   So the new IR entry will look like (note that the name field actually stores 
the index to the node table
   ```
   [
     {"type_key": "TypeVar", "attrs" : { "name": "2" }},
     {type_key: "runtime.String", repr_str: "myname"}
   ]
   ```
   This mechanism is baked into json serialization so it is a bit hard to move 
out. Of course we could also say that String should mostly be printable, and 
use a special serialization(e.g. just print as str when it is an old  str 
attribute) Thet is a special case though and makes the json serialization 
harder to work with when directly serialize a String object itself.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to