libaihong commented on pull request #5428:
URL: https://github.com/apache/incubator-tvm/pull/5428#issuecomment-619465094


   > 
   > 
   > Could you please add a few tests.Do you mean loading uchar2x4? We could 
load/store them as uint16_t x 4. I do not see similar code in PrintType below:
   > 
   > 
https://github.com/apache/incubator-tvm/blob/master/src/target/source/codegen_cuda.cc#L186
   
   I've added some unit test. 
   
   
   > 
   > 
   > Could you please add a few tests.Do you mean loading uchar2x4? We could 
load/store them as uint16_t x 4. I do not see similar code in PrintType below:
   > 
   > 
https://github.com/apache/incubator-tvm/blob/master/src/target/source/codegen_cuda.cc#L186
   
   I've added some unit test.
   This modification only add code for char2 when the lanes is 2.  And when 
lanes is 4, it will use the old logic and will not loading uchar4.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to