areusch commented on a change in pull request #5417:
URL: https://github.com/apache/incubator-tvm/pull/5417#discussion_r415983620
##########
File path: src/runtime/micro/host_driven/utvm_runtime.c
##########
@@ -34,89 +34,148 @@ extern "C" {
#include "utvm_runtime.h"
-// Task pointers must be patched before calling a function.
-UTVMTask utvm_task = {
- .func = NULL,
- .arg_values = NULL,
- .arg_type_codes = NULL,
- .num_args = 0,
-};
-
-size_t utvm_word_size = 0; // NOLINT(*)
+// TODO(areusch): move defines into header
+#define TASK_QUEUE_SIZE 20
+volatile UTVMTask utvm_tasks[TASK_QUEUE_SIZE] = { };
+volatile uint32_t utvm_num_tasks = 0;
+volatile uint32_t utvm_task_times[TASK_QUEUE_SIZE] = { };
// These pointers are patched at load time to point to the workspace section.
-char* utvm_workspace_start = NULL; // NOLINT(*)
-char* utvm_workspace_end = NULL; // NOLINT(*)
-char* utvm_workspace_curr = NULL; // NOLINT(*)
+volatile char* utvm_workspace_start = NULL; // NOLINT(*)
+volatile char* utvm_workspace_end = NULL; // NOLINT(*)
+volatile char* utvm_workspace_curr = NULL; // NOLINT(*)
+#define MAX_WS_ALLOCS 10
+volatile char* utvm_alloc_ends[MAX_WS_ALLOCS] = {}; // NOLINT(*)
+volatile uint32_t utvm_alloc_idx = 0;
// Keep track of how many active allocations there are on the workspace.
-size_t utvm_num_active_allocs = 0;
+volatile uint32_t utvm_num_active_allocs = 0;
+
+volatile uint32_t utvm_word_size = 0;
-const char* utvm_last_error = NULL; // NOLINT(*)
-int32_t utvm_return_code = 0; // NOLINT(*)
+volatile int32_t utvm_last_error = 0; // NOLINT(*)
-uint32_t utvm_task_time = 0;
+volatile uint32_t utvm_done = 0;
// Gets called by UTVMInit, after device-specific initialization is finished.
void UTVMMain() {
+ utvm_done = 0;
+ // loss of precision should be fine here, since we only care about the lower
bits
+ if (((uint32_t) utvm_workspace_start) % utvm_word_size) {
Review comment:
downcasting to a smaller integral type is well-defined, but deciding
what to do when the cast is missing can be less well-defined (i believe this
problem is fixed in c++ and potentially newer C). it's fine here. another
embedded way to fix this is to assume utvm_word_size is a power of two # of
bytes, and do
`if (utvm_workspace_start & (utvm_word_size - 1))`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
