areusch commented on a change in pull request #5417:
URL: https://github.com/apache/incubator-tvm/pull/5417#discussion_r415958560
##########
File path: python/tvm/micro/device/base.py
##########
@@ -92,71 +95,142 @@ def create_micro_lib_base(
options : List[str]
additional options to pass to GCC
+
+ lib_src_paths : Optional[List[str]]
+ paths to additional source files to be compiled into the library
"""
+ # look at these (specifically `strip`):
+ #
https://stackoverflow.com/questions/15314581/g-compiler-flag-to-minimize-binary-size
base_compile_cmd = [
- f"{toolchain_prefix}gcc",
- "-std=c11",
- "-Wall",
- "-Wextra",
- "--pedantic",
- "-c",
- "-O0",
- "-g",
- "-nostartfiles",
- "-nodefaultlibs",
- "-nostdlib",
- "-fdata-sections",
- "-ffunction-sections",
+ f'{toolchain_prefix}gcc',
Review comment:
undid all the quote conversions, except those that made sense (i.e. to
avoid escapes, as in f'unknown variable "{var}"'). can you point out any other
changes you want me to revert? I didn't originally author most of this code so
I don't have all the context in my head.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
