liangfu commented on a change in pull request #5492:
URL: https://github.com/apache/incubator-tvm/pull/5492#discussion_r419019525
##########
File path: src/runtime/hexagon/sim/driver/CMakeLists.txt
##########
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
[VTA.cmake](https://github.com/apache/incubator-tvm/blob/master/cmake/modules/VTA.cmake)
is an example of CMake config for building standalone lib. Also, given that
it's unfriendly to require users to navigate to src/runtime/hexagon/sim/driver,
and having CMakeLists.txt exist under src directory seems a bit odd to me, I
think it's better to put this under `cmake`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
