kparzysz-quic commented on a change in pull request #5492:
URL: https://github.com/apache/incubator-tvm/pull/5492#discussion_r419427426
##########
File path: src/runtime/hexagon/sim/driver/CMakeLists.txt
##########
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
1. It's not just for a standalone lib/program, it's a standalone
CMakeLists.txt. All other cmake files in the cmake directory are included in
the main CMakeLists.txt. This one isn't.
2. The driver has to be compiled with hexagon-clang. That doesn't correlate
with any other compilation that uses hexagon-clang (libtvm_runtime.so needs to
be compiled for Hexagon in both cases, when using a simulator and a hardware
device), so it shouldn't really be included in the main CMakeFile.txt.
I was planning to add it as a dependency to the main CMakeLists.txt after
it's checked in. This would remove the need for manual running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
