areusch commented on a change in pull request #5484:
URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419611904
##########
File path: python/tvm/_ffi/base.py
##########
@@ -48,8 +48,11 @@ def _load_lib():
"""Load libary by searching possible path."""
lib_path = libinfo.find_lib_path()
lib = ctypes.CDLL(lib_path[0], ctypes.RTLD_GLOBAL)
- # DMatrix functions
lib.TVMGetLastError.restype = ctypes.c_char_p
+ # Put the libpath to LD_LIBRARY_PATH
+ # will be useful for pipe session to find libtvm
+ os.environ["LD_LIBRARY_PATH"] = "%s:%s" % (
Review comment:
is this just to make minrpcserver work? if so, could we just add in the
search path in that binary rather than changing LD_LIBRARY_PATH for all library
loads here? or at least, can you revert the change when you're done?
i think this means that all hooks that invoke a subprocess inherit the
modified LD_LIBRARY_PATH
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
