tqchen commented on a change in pull request #5484:
URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419623838
##########
File path: python/tvm/_ffi/base.py
##########
@@ -48,8 +48,11 @@ def _load_lib():
"""Load libary by searching possible path."""
lib_path = libinfo.find_lib_path()
lib = ctypes.CDLL(lib_path[0], ctypes.RTLD_GLOBAL)
- # DMatrix functions
lib.TVMGetLastError.restype = ctypes.c_char_p
+ # Put the libpath to LD_LIBRARY_PATH
+ # will be useful for pipe session to find libtvm
+ os.environ["LD_LIBRARY_PATH"] = "%s:%s" % (
Review comment:
Given that it makes sense to make libtvm available to subprocesses, I
think we can leave it as it is. While setting rpath for the binary would work
if the binary is on the same machine, it may not work after we send it through
an RPC, so it might be helpful to keep the env variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
