kevinthesun commented on a change in pull request #5588: URL: https://github.com/apache/incubator-tvm/pull/5588#discussion_r427046505
########## File path: src/relay/op/tensor/transform.cc ########## @@ -2248,6 +2248,9 @@ bool GatherNDRel(const Array<Type>& types, int num_inputs, const Attrs& attrs, Array<IndexExpr> oshape; for (size_t i = 1; i < kdim + 1; ++i) oshape.push_back(indices->shape[i]); for (size_t i = mdim->value; i < ndim; ++i) oshape.push_back(data->shape[i]); + if (oshape.size() == 0) { Review comment: Is this necessary? Looks like we just use a tensor of shape (1,) to replace scalar, and they should be the same? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org