kevinthesun commented on a change in pull request #5588:
URL: https://github.com/apache/incubator-tvm/pull/5588#discussion_r427556068
##########
File path: src/relay/op/tensor/transform.cc
##########
@@ -2248,6 +2248,9 @@ bool GatherNDRel(const Array<Type>& types, int
num_inputs, const Attrs& attrs,
Array<IndexExpr> oshape;
for (size_t i = 1; i < kdim + 1; ++i) oshape.push_back(indices->shape[i]);
for (size_t i = mdim->value; i < ndim; ++i) oshape.push_back(data->shape[i]);
+ if (oshape.size() == 0) {
Review comment:
OK. I think I understand now.
https://github.com/apache/incubator-tvm/blob/c71989a9db0d60f6a8077596e2915f9b4537e093/topi/include/topi/transform.h#L1010-L1012
In topi we do the same thing, it's good to align with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
